Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web3js): fix RPC URL and link #55

Merged
merged 1 commit into from
Aug 29, 2024
Merged

fix(web3js): fix RPC URL and link #55

merged 1 commit into from
Aug 29, 2024

Conversation

danforbes
Copy link
Contributor

  • Web3.js should be instantiated with an L1 RPC provider
  • Fix link
  • Minor formatting fix

@danforbes danforbes requested a review from a team as a code owner August 29, 2024 12:17
@danforbes danforbes mentioned this pull request Aug 29, 2024
Closed
jennyg0
jennyg0 approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@jennyg0 jennyg0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! will close the other PR

@jennyg0 jennyg0 merged commit 939b796 into zkSync-Community-Hub:main Aug 29, 2024
10 checks passed
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 1.11.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@danforbes danforbes deleted the fix/web3js/rpc-url branch August 29, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennyg0 jennyg0 jennyg0 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danforbes @jennyg0